mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 34894: Add new message for Traffic Control statistics
Date Tue, 02 Jun 2015 20:39:04 GMT


> On June 1, 2015, 6:32 p.m., Chi Zhang wrote:
> > include/mesos/mesos.proto, lines 543-545
> > <https://reviews.apache.org/r/34894/diff/1/?file=975745#file975745line543>
> >
> >     Maybe some comments for the three names? (kinda the reason you are not using
'repeated' of TrafficControlStatistics in ResourceStatistics?)

Having talk this over, we will convert this to a repeated structure with id fields which are
defined in the port mapping isolator (disk volume reporting will need to use a similar structure).


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86033
-----------------------------------------------------------


On June 1, 2015, 4:40 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34894/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 4:40 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add new message for Traffic Control statistics
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4 
> 
> Diff: https://reviews.apache.org/r/34894/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message