mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Date Tue, 02 Jun 2015 20:10:13 GMT


> On June 1, 2015, 9:40 p.m., Ben Mahler wrote:
> > include/mesos/mesos.proto, lines 577-580
> > <https://reviews.apache.org/r/34748/diff/3/?file=975577#file975577line577>
> >
> >     We've lost the important information (what does it mean for these to be unset?).
Could you revert the comment changes here?
> 
> Bartek Plotka wrote:
>     Do you mean the "Resource usage is for an executor" sentence or sth else?

Oh, i think you ment:
```
required SlaveID slave_id = 1;
required FrameworkID framework_id = 2;
```
So the SlaveID is not needed, because (in current implementation) ResourceUsage is for internal
usage only. 
And FrameworkID is included in ExecutorInfo.

Does that make sense?


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86092
-----------------------------------------------------------


On June 2, 2015, 7:40 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 7:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon
Konefal, and Vinod Kone.
> 
> 
> Bugs: MESOS-2772
>     https://issues.apache.org/jira/browse/MESOS-2772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
> 
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator
and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since
it's not used anywhere else.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 
> 
> Diff: https://reviews.apache.org/r/34748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message