mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 34426: Report per-container metrics for network bandwidth throttling
Date Tue, 02 Jun 2015 00:41:30 GMT


> On June 1, 2015, 6:44 p.m., Cong Wang wrote:
> > src/linux/routing/queueing/internal.hpp, line 284
> > <https://reviews.apache.org/r/34426/diff/8/?file=975301#file975301line284>
> >
> >     The lastest mesos code already relies on libnl 3.2.26, so not sure how much
sense it makes to keep the backward compatibility here.

3.2.26 is not yet required as we have not pushed the last of the fq_codel changes to head.
 Lets leave this as a TODO until the dependency is committed to master.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review86040
-----------------------------------------------------------


On May 31, 2015, 7:53 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34426/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 7:53 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2665
>     https://issues.apache.org/jira/browse/MESOS-2665
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report the network statistics from libnl
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241 
>   src/linux/routing/queueing/fq_codel.hpp 7de1e31d4c43ac9cbffab1e472ea51140719f900 
>   src/linux/routing/queueing/fq_codel.cpp 64b5c73e8cfa672141ddb663e879c58b4babfdbc 
>   src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed 
>   src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699 
>   src/linux/routing/queueing/internal.hpp d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 
>   src/linux/routing/queueing/statistics.hpp PRE-CREATION 
>   src/linux/routing/queueing/statistics.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34426/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message