mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 34904: Added help for state.json
Date Mon, 01 Jun 2015 21:40:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34904/#review86093
-----------------------------------------------------------


looking good. some minor things and we will get this committed.


src/master/http.cpp
<https://reviews.apache.org/r/34904/#comment137990>

    s/json/JSON/
    
    also, we want to provide more info in the help than just "information about the state
of master". how about mentioning that it provides information about frameworks, slaves, tasks
and executors running in the cluster?



src/master/http.cpp
<https://reviews.apache.org/r/34904/#comment137991>

    why the extra new line?



src/master/http.cpp
<https://reviews.apache.org/r/34904/#comment137994>

    s/json/JSON/



src/master/http.cpp
<https://reviews.apache.org/r/34904/#comment137996>

    This endpoint shows the information about the roles that the master is configured with.
It has nothing to do with running framework.


- Vinod Kone


On June 1, 2015, 8:45 p.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34904/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: mesos-2277
>     https://issues.apache.org/jira/browse/mesos-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for roles.json, state-summary and state.json
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 
>   src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 
> 
> Diff: https://reviews.apache.org/r/34904/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message