mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Date Mon, 01 Jun 2015 21:40:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86092
-----------------------------------------------------------


High level looks good, just some minor comments.


include/mesos/mesos.proto
<https://reviews.apache.org/r/34748/#comment137989>

    This comment seems likely to become stale as the code evolves, and I'm not sure it's providing
a lot of value, can we remove it?



include/mesos/mesos.proto
<https://reviews.apache.org/r/34748/#comment137992>

    What does it mean that this is re-used?
    
    Let's remove this NOTE and the reference to the "old interface" since it no longer exists.



include/mesos/mesos.proto
<https://reviews.apache.org/r/34748/#comment137995>

    We've lost the important information (what does it mean for these to be unset?). Could
you revert the comment changes here?



src/slave/monitor.cpp
<https://reviews.apache.org/r/34748/#comment137988>

    Looks like this should be removed now?


- Ben Mahler


On June 1, 2015, 9:26 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon
Konefal, and Vinod Kone.
> 
> 
> Bugs: MESOS-2772
>     https://issues.apache.org/jira/browse/MESOS-2772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
> 
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator
and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since
it's not used anywhere else.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 
>   src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225 
>   src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e 
> 
> Diff: https://reviews.apache.org/r/34748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message