mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop
Date Mon, 01 Jun 2015 20:19:36 GMT


> On April 19, 2015, 10:55 p.m., Adam B wrote:
> > LGTM, barring a question about ordering/synchronization. I'll let another committer
take a look before we commit it.
> 
> Adam B wrote:
>     Would also like to see a successful ReviewBot pass. That MasterFailover segfault
seems like it could be related to your detector changes.
> 
> Niklas Nielsen wrote:
>     Hey Robert, do you need some help on this patch?

Ping :) Let's get some cadence behind this, or drop it (and reopen when we can work on this
again).


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33208/#review80655
-----------------------------------------------------------


On April 14, 2015, 10:23 p.m., Robert Lacroix wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33208/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1634
>     https://issues.apache.org/jira/browse/MESOS-1634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the Mesos Scheduler Driver stops, it does not delete the detector process before
the object is garbage collected, which leaves ZooKeeper connections hanging around unnecessarily.
This deletes the process on stop as well, not only on destruction.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 66fd2b3146568900356cc48e0f17c6720665ae80 
> 
> Diff: https://reviews.apache.org/r/33208/diff/
> 
> 
> Testing
> -------
> 
> make check, manual testing
> 
> 
> Thanks,
> 
> Robert Lacroix
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message