mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.
Date Mon, 01 Jun 2015 17:59:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34830/#review86006
-----------------------------------------------------------



src/linux/routing/queueing/fq_codel.cpp
<https://reviews.apache.org/r/34830/#comment137853>

    ignore if you have done in a different patch:
    
    egress::ROOT? (You had ingress::ROOT)



src/linux/routing/queueing/ingress.hpp
<https://reviews.apache.org/r/34830/#comment137850>

    a bit confused by "an ingress qdisc on the egress side of the link"



src/linux/routing/queueing/ingress.hpp
<https://reviews.apache.org/r/34830/#comment137851>

    a bit confused by "an ingress qdisc on the egress side of the link"
    
    I saw this in other places too.



src/linux/routing/queueing/ingress.cpp
<https://reviews.apache.org/r/34830/#comment137845>

    Two blank lines between the functions. 
    
    here and other places.



src/linux/routing/queueing/internal.hpp
<https://reviews.apache.org/r/34830/#comment137855>

    reinterpret_cast is the preferred c++ way, but I am not sure if the codebase has done
similiar casting with this before?.
    
    If using this introdue consistency, use another patch to do it all?



src/linux/routing/queueing/internal.hpp
<https://reviews.apache.org/r/34830/#comment137844>

    Fix the space before "This"


- Chi Zhang


On May 30, 2015, 9 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34830/
> -----------------------------------------------------------
> 
> (Updated May 30, 2015, 9 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2781
>     https://issues.apache.org/jira/browse/MESOS-2781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix routing ingress/fq_codel search returning wrong qdisc.
> 
> Add new checking to verify that operations occur on the correct interface and change
the behaviour of create() operation to return false rather than an error if creation fails
if the interface does not exist (now consistent with exists() and remove()).
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/queueing/fq_codel.hpp 7de1e31d4c43ac9cbffab1e472ea51140719f900 
>   src/linux/routing/queueing/fq_codel.cpp 64b5c73e8cfa672141ddb663e879c58b4babfdbc 
>   src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed 
>   src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699 
>   src/linux/routing/queueing/internal.hpp d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 
> 
> Diff: https://reviews.apache.org/r/34830/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message