mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 34892: Reintroduced chown stdout stderr in FetcherProcess::run().
Date Mon, 01 Jun 2015 15:55:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34892/#review85991
-----------------------------------------------------------

Ship it!


As a follow up, let's figure out how to create tests for things like this that require another
user.

- Benjamin Hindman


On June 1, 2015, 3:42 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34892/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> rb30774 erased a call to chown() in FetcherProcess::run() that should have stayed there.
It gets reintroduced here.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.hpp 16553ffa083fbbb0495a50e7c18223454b098ff1 
>   src/slave/containerizer/fetcher.cpp d4f127ad939c897da19aecdff48ea09bc1c9e2fb 
>   src/tests/fetcher_cache_tests.cpp bd53fc1d45047e66b7710dd68ea4442c9adfe002 
>   src/tests/mesos.hpp 4fcf0b7742b75b93c4ee37adb1cd65ff5f1e18cb 
>   src/tests/mesos.cpp 830d362c81e98092ae671d5d5f69bb865d33ba3a 
> 
> Diff: https://reviews.apache.org/r/34892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message