mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching
Date Mon, 01 Jun 2015 13:33:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review85978
-----------------------------------------------------------



src/cli/mesos-ps
<https://reviews.apache.org/r/34887/#comment137816>

    How about add `bytes = float(bytes)` at the beginning. And don't need change `1024` to
`1024.0` at below code.


- haosdent huang


On June 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
>     https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the real Mem
Allocated is greater than 1G
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> weitao zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message