mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 34816: Changed TestResourceEstimator to be mocked.
Date Mon, 01 Jun 2015 05:37:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
-----------------------------------------------------------

(Updated June 1, 2015, 5:37 a.m.)


Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.


Changes
-------

Fixed last issue.


Repository: mesos


Description
-------

This patch prepares Resource Estimator tests for modularized ResourceEstimator.

It includes:
1. Made oversubscription_test to be typed_test.
2. TestResourceEstimator changed to be a templated MockResourceEstimator with mocked methods
- to inject resources and test plumbing between RE and Slave.


Diffs (updated)
-----

  src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b 
  src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f 

Diff: https://reviews.apache.org/r/34816/diff/


Testing
-------

make check


Thanks,

Bartek Plotka


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message