-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/#review85405
-----------------------------------------------------------



src/Makefile.am
<https://reviews.apache.org/r/34321/#comment136956>

    kill white space.



src/Makefile.am
<https://reviews.apache.org/r/34321/#comment136969>

    this is removed from the Makefile but not from the source tree?



src/linux/routing/filter/handle.hpp
<https://reviews.apache.org/r/34321/#comment136963>

    why the change? we strive for the guard names to match the file path.



src/linux/routing/filter/handle.hpp
<https://reviews.apache.org/r/34321/#comment136964>

    wrap at 70.



src/linux/routing/filter/handle.hpp
<https://reviews.apache.org/r/34321/#comment136967>

    s/has/hash/



src/linux/routing/queueing/handle.hpp
<https://reviews.apache.org/r/34321/#comment136974>

    why protected when you have a get()?


- Vinod Kone


On May 26, 2015, 9:59 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34321/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 9:59 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: mesos-2665
>     https://issues.apache.org/jira/browse/mesos-2665
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Merge class Handle which is duplicated between filter/handle and queueing/handle.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
>   src/linux/routing/filter/basic.hpp 99b0b058633403e334e7230dfa7d705c99b3cb10 
>   src/linux/routing/filter/basic.cpp 755be7de5c43c2f3b336af6cb47af9c97a21218c 
>   src/linux/routing/filter/filter.hpp 024582cf8274da2e5bcccc4ebd00fcf83d6930e2 
>   src/linux/routing/filter/handle.hpp 190177441bc95cf77690dbdeca189a816c6e2324 
>   src/linux/routing/filter/icmp.hpp d55eeee8f1e31036e75780c52690e812de265ec6 
>   src/linux/routing/filter/icmp.cpp 60703e727ecab9557911ab0562773771db51db90 
>   src/linux/routing/filter/internal.hpp c74098dab97807084e6630998da354265680c763 
>   src/linux/routing/filter/ip.hpp 62bb5f89d35fc9622fca303aa01a789fcfbf2f76 
>   src/linux/routing/filter/ip.cpp 0d25e2d4f0ac4c3f151ad40e796dbdbc54dba9fa 
>   src/linux/routing/queueing/fq_codel.hpp 4f67ab7d64afea96a07dfcf36769a9c667749a00 
>   src/linux/routing/queueing/fq_codel.cpp 02ad8df7814c0e549a9ca9aef39777684e6abdcb 
>   src/linux/routing/queueing/handle.hpp 5f0cb7775f9190caba6b85cabf9019a97b2a7de2 
>   src/linux/routing/queueing/handle.cpp cd34fc41a0b4233520a606cb439b286777c6a995 
>   src/linux/routing/queueing/ingress.hpp b323a7f6daed828327d6d9e9740df81582e0ba2b 
>   src/linux/routing/queueing/ingress.cpp 47c73376097d70819defdee31a6d1e446df6b8ba 
>   src/linux/routing/queueing/internal.hpp 7c6c4d3d960b9a4bf44dcf482212317522353d69 
>   src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa 
> 
> Diff: https://reviews.apache.org/r/34321/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>