From reviews-return-1238-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu May 21 05:46:11 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB7A618779 for ; Thu, 21 May 2015 05:46:11 +0000 (UTC) Received: (qmail 62940 invoked by uid 500); 21 May 2015 05:46:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 62916 invoked by uid 500); 21 May 2015 05:46:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62902 invoked by uid 99); 21 May 2015 05:46:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 May 2015 05:46:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4EC9B1DD5EF; Thu, 21 May 2015 05:46:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7259736543134514389==" MIME-Version: 1.0 Subject: Review Request 34529: Add non-const reference version of Option::get. From: "Mark Wang" To: "Mark Wang" , "mesos" Date: Thu, 21 May 2015 05:46:10 -0000 Message-ID: <20150521054610.17212.65639@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mark Wang" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34529/ X-Sender: "Mark Wang" Reply-To: "Mark Wang" X-ReviewRequest-Repository: mesos --===============7259736543134514389== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/ ----------------------------------------------------------- Review request for mesos. Bugs: MESOS-2716 https://issues.apache.org/jira/browse/MESOS-2716 Repository: mesos Description ------- Add non-const reference version of Option::get. Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp ea79b501d9ed7b7da9636ce9c9c590738a586993 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c Diff: https://reviews.apache.org/r/34529/diff/ Testing ------- make check Thanks, Mark Wang --===============7259736543134514389==--