From reviews-return-1101-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue May 19 22:48:37 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 180A11788F for ; Tue, 19 May 2015 22:48:37 +0000 (UTC) Received: (qmail 41210 invoked by uid 500); 19 May 2015 22:48:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41185 invoked by uid 500); 19 May 2015 22:48:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41170 invoked by uid 99); 19 May 2015 22:48:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 22:48:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C3C601DD580; Tue, 19 May 2015 22:48:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1530982483271951815==" MIME-Version: 1.0 Subject: Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator. From: "Ian Downes" To: "Joris Van Remoortere" , "Niklas Nielsen" , "Vinod Kone" Cc: "Ian Downes" , "mesos" Date: Tue, 19 May 2015 22:48:35 -0000 Message-ID: <20150519224835.14201.74280@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ian Downes" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34310/ X-Sender: "Ian Downes" References: <20150519194242.14201.44927@reviews.apache.org> In-Reply-To: <20150519194242.14201.44927@reviews.apache.org> Reply-To: "Ian Downes" X-ReviewRequest-Repository: mesos --===============1530982483271951815== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 19, 2015, 12:42 p.m., Vinod Kone wrote: > > My high leve comment: > > > > Lets add the following check/invariant in the master: > > > > "An executor and all its tasks should all use regular resources or should all use revocable resources". > > > > We can relax this policy in the future when we have better QoS mechanisms in place. Does that make sense? https://issues.apache.org/jira/browse/MESOS-2753 - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review84371 ----------------------------------------------------------- On May 19, 2015, 3:43 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34310/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 3:43 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2652 > https://issues.apache.org/jira/browse/MESOS-2652 > > > Repository: mesos > > > Description > ------- > > Use IDLE scheduling for revocable CPU in cgroups isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.hpp ff4a9dbdb1b655e71bf87dcee8fe62433d396f52 > src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5c6e2844fe1a10815956569194b6f56681 > > Diff: https://reviews.apache.org/r/34310/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============1530982483271951815==--