From reviews-return-827-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu May 14 10:55:55 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C0D910180 for ; Thu, 14 May 2015 10:55:55 +0000 (UTC) Received: (qmail 46465 invoked by uid 500); 14 May 2015 10:55:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 46440 invoked by uid 500); 14 May 2015 10:55:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46425 invoked by uid 99); 14 May 2015 10:55:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 10:55:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D70F71DD2B4; Thu, 14 May 2015 10:55:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5051287222627422282==" MIME-Version: 1.0 Subject: Re: Review Request 29507: Added Configurable Slave Ping Timeouts From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Ben Mahler" Cc: "Adam B" , "Mesos ReviewBot" , "mesos" Date: Thu, 14 May 2015 10:55:54 -0000 Message-ID: <20150514105554.1460.34718@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29507/ X-Sender: "Mesos ReviewBot" References: <20150514100159.1460.84829@reviews.apache.org> In-Reply-To: <20150514100159.1460.84829@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============5051287222627422282== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review83747 ----------------------------------------------------------- Patch looks great! Reviews applied: [29507] All tests passed. - Mesos ReviewBot On May 14, 2015, 10:01 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29507/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 10:01 a.m.) > > > Review request for mesos, Ben Mahler and Niklas Nielsen. > > > Bugs: MESOS-2110 > https://issues.apache.org/jira/browse/MESOS-2110 > > > Repository: mesos > > > Description > ------- > > Added new --slave_ping_timeout and --max_slave_ping_timeouts flags > to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs) > and DEFAULT_MAX_SLAVE_PING_TIMEOUTS (5). > > These can be extended if slaves are expected/allowed to be down for > longer than a minute or two. > > Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage. > > Beware that this affects recovery from network timeouts as well as > actual slave node/process failover. > > > Diffs > ----- > > docs/configuration.md 54c4e31 > docs/upgrades.md 2a15694 > src/master/constants.hpp c386eab > src/master/constants.cpp 9ee17e9 > src/master/flags.hpp 996cf38 > src/master/flags.cpp 5798989 > src/master/master.cpp eaea79d > src/messages/messages.proto 19e2444 > src/slave/constants.hpp df02043 > src/slave/constants.cpp 07f699a > src/slave/slave.hpp b62ed7b > src/slave/slave.cpp 132f83e > src/tests/partition_tests.cpp f7ee3ab > src/tests/slave_recovery_tests.cpp c036e9c > src/tests/slave_tests.cpp acae497 > > Diff: https://reviews.apache.org/r/29507/diff/ > > > Testing > ------- > > Manually tested slave failover/shutdown with master using different --slave_ping_timeout and --max_slave_ping_timeouts. > Ran unit tests with shorter non-default values for ping timeouts. > `make check` with new unit tests: ShortPingTimeoutUnreachableMaster and ShortPingTimeoutUnreachableSlave > > > Thanks, > > Adam B > > --===============5051287222627422282==--