From reviews-return-491-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed May 6 23:01:51 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7C3D186EC for ; Wed, 6 May 2015 23:01:50 +0000 (UTC) Received: (qmail 14353 invoked by uid 500); 6 May 2015 23:01:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 14329 invoked by uid 500); 6 May 2015 23:01:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14313 invoked by uid 99); 6 May 2015 23:01:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2015 23:01:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E44741DD1FC; Wed, 6 May 2015 23:01:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3802223578822623109==" MIME-Version: 1.0 Subject: Re: Review Request 33918: Added resources estimator abstraction for oversubscription. From: "Vinod Kone" To: "Joris Van Remoortere" , "Niklas Nielsen" , "Ben Mahler" , "Vinod Kone" Cc: "Jie Yu" , "mesos" Date: Wed, 06 May 2015 23:01:51 -0000 Message-ID: <20150506230151.1562.71968@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/33918/ X-Sender: "Vinod Kone" References: <20150506223531.1563.26855@reviews.apache.org> In-Reply-To: <20150506223531.1563.26855@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos --===============3802223578822623109== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82760 ----------------------------------------------------------- LGTM except for the naming. I would call it ResourceEstimator instead of Resource*s*Estimator. The former is just easier to pronounce. Also, this is to be consistent with things like ResourceMonitor and StatusUpdateManager which also deal with multiples of resources and status updates. - Vinod Kone On May 6, 2015, 10:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33918/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:35 p.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2649 > https://issues.apache.org/jira/browse/MESOS-2649 > > > Repository: mesos > > > Description > ------- > > Added resources estimator abstraction for oversubscription. > > This patch defines the interface of the resources estimator and creates a default stub implementation. > > > Diffs > ----- > > include/mesos/slave/resources_estimator.hpp PRE-CREATION > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/slave/resources_estimator.hpp PRE-CREATION > src/slave/resources_estimator.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============3802223578822623109==--