mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 29406: Introduce libevent ssl socket.
Date Sat, 30 May 2015 05:29:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------

(Updated May 30, 2015, 5:29 a.m.)


Review request for Michael Park.


Changes
-------

rebasing. addressing some of mpark's issues.


Bugs: MESOS-1913
    https://issues.apache.org/jira/browse/MESOS-1913


Repository: mesos


Description
-------

Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)

TODO:
Restrict SSL version more tightly
Track down leak in crypto from accept


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 6e8972fc4f6e0867874e30beb435a35f1ecb9c79 
  3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b

  3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 
  3rdparty/libprocess/src/libevent.cpp d27fcb9d1b254b6bb7f77817819931c95d610582 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/openssl.hpp PRE-CREATION 
  3rdparty/libprocess/src/openssl.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp e3de3cd6b536aaaf59784360aed546512dd04dc9 
  3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 

Diff: https://reviews.apache.org/r/29406/diff/


Testing
-------

make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message