mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 34633: Added QoS Controller test.
Date Fri, 29 May 2015 19:23:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34633/#review85775
-----------------------------------------------------------



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34633/#comment137551>

    s/received/qosCorrection/



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34633/#comment137552>

    Why not implement the TODO?
    
    s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ?


- Vinod Kone


On May 23, 2015, 5:07 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34633/
> -----------------------------------------------------------
> 
> (Updated May 23, 2015, 5:07 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added new QoS Controller test which use the TestQoSController to fill the correction
queue and verify the slave receiving corrections.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 
> 
> Diff: https://reviews.apache.org/r/34633/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message