mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <>
Subject Re: Review Request 29507: Added Configurable Slave Ping Timeouts
Date Thu, 28 May 2015 23:13:12 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 28, 2015, 4:13 p.m.)

Review request for mesos, Ben Mahler and Niklas Nielsen.


Updated diff with minor feedback, updated description to mention slave_reregister_timeout

Bugs: MESOS-2110

Repository: mesos

Description (updated)

Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs)
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.

Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage.
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.

Also fixed the log message in recoveredSlavesTimeout() to correctly
reference flags.slave_reregister_timeout instead of the unrelated
ping timeouts.

Diffs (updated)

  docs/ 5a41477 
  docs/ 355307a 
  src/master/constants.hpp 57cf8fb 
  src/master/constants.cpp 8c7174a 
  src/master/flags.hpp 84fa238 
  src/master/flags.cpp 49d953a 
  src/master/master.cpp 1526f59 
  src/messages/messages.proto 39dac72 
  src/slave/constants.hpp 206d439 
  src/slave/constants.cpp d8d2f98 
  src/slave/slave.hpp 0207eaf 
  src/slave/slave.cpp b4d2029 
  src/tests/partition_tests.cpp f7ee3ab 
  src/tests/slave_recovery_tests.cpp c036e9c 
  src/tests/slave_tests.cpp acae497 



Manually tested slave failover/shutdown with master using different --slave_ping_timeout and
Ran unit tests with shorter non-default values for ping timeouts.
`make check` with new unit tests: ShortPingTimeoutUnreachableMaster and ShortPingTimeoutUnreachableSlave


Adam B

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message