mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module
Date Thu, 28 May 2015 00:39:30 GMT


> On May 27, 2015, 5:24 p.m., Vinod Kone wrote:
> > src/examples/test_resource_estimator_module.cpp, lines 40-44
> > <https://reviews.apache.org/r/34662/diff/6/?file=973211#file973211line40>
> >
> >     I'm confused. 'parameters' are unused and the passed 'flags' are empty?

TestResourceEstimator need to have a 'create()' which takes a Flags object, to be consistent
with modules typed tests; so it's is just to avoid another 'create()'. Would you prefer that?

Parameters could be removed - @Bartek Plotka, mind removing that one? :)


> On May 27, 2015, 5:24 p.m., Vinod Kone wrote:
> > src/tests/resource_estimator.hpp, line 47
> > <https://reviews.apache.org/r/34662/diff/6/?file=973217#file973217line47>
> >
> >     s/consistent/to be consistent/

Should be fixed.


> On May 27, 2015, 5:24 p.m., Vinod Kone wrote:
> > src/tests/resource_estimator.hpp, lines 55-57
> > <https://reviews.apache.org/r/34662/diff/6/?file=973217#file973217line55>
> >
> >     Hmm. I'm confused. Why the change in semantics here?

The typed tests for modules will give you a ResourceEstimator - not a TestResourceEstimator.
Therefore, we cannot have the 'estimate()' convenience method on the estimator. Does this
make sense?


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85473
-----------------------------------------------------------


On May 27, 2015, 5:04 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
> 
> 
> Bugs: MESOS-2650
>     https://issues.apache.org/jira/browse/MESOS-2650
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added *ResourceEstimator* (RE) module interface. 
> Added *TestResourceEstimator* example module. (Test *ResourceEstimator* module)
> Moved *TestResourceEstimator* to seperate file from *tests/mesos.hpp*
> Changed *oversubscription_tests* to be typed_tested (for normal RE and RE module)
> 
> NOTE: The example modules were good enough for other modules' unit tests, however RE
had to be extended - to push particular *Resources* to slave.
> 
> In future if we implement https://issues.apache.org/jira/browse/MESOS-2764, we will be
able to inject stubed *Resources* in better way.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/resource_estimator.hpp PRE-CREATION 
>   src/Makefile.am 28669f6d2d1a6a9f616ff4a288b9038235a23595 
>   src/examples/test_resource_estimator_module.cpp PRE-CREATION 
>   src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be 
>   src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba 
>   src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8 
>   src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29 
>   src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 
>   src/tests/resource_estimator.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message