mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 34140: AppC image store
Date Wed, 27 May 2015 23:10:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34140/#review85456
-----------------------------------------------------------


Disk usage by the store is currently unbounded.  Do we need to add the ability to discover
or limit the size of the image store?

Will you limit the number of fetchers that can be run concurrently to limit the performance
impact to existing containers?


src/slave/containerizer/provisioners/appc/store.cpp
<https://reviews.apache.org/r/34140/#comment137028>

    And log the error?



src/slave/containerizer/provisioners/appc/store.cpp
<https://reviews.apache.org/r/34140/#comment137029>

    Does the mesos-fetcher choose the name or is that down to the requester?  Can we assume
that the name is safe to use?  Why not pass it from StoreProcess rather than try to work it
out after the fact?



src/slave/containerizer/provisioners/appc/store.cpp
<https://reviews.apache.org/r/34140/#comment137030>

    We probably want to keep a track on how long it took so we can debug performance issues.



src/slave/containerizer/provisioners/appc/store.cpp
<https://reviews.apache.org/r/34140/#comment137031>

    Do we cache the hashes?



src/slave/containerizer/provisioners/appc/store.cpp
<https://reviews.apache.org/r/34140/#comment137032>

    Why not do the decompress, hash & untar as a pipeline to reduce disk usage?


- Paul Brett


On May 26, 2015, 6:25 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34140/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Images are fetched into the store (after discovery). Stored images are
> currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 
>   src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
> 
> Diff: https://reviews.apache.org/r/34140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message