mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.
Date Wed, 27 May 2015 18:46:25 GMT


> On May 27, 2015, 6:21 p.m., Vinod Kone wrote:
> > What's the motivation for pulling out these constatns to the file scope instead
of class scope as it was before? I don't follow what you mean by "easier sharing".

I want to use them in later tests outside the PortMappingIsolatorTest scope in which they
currently reside.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85402
-----------------------------------------------------------


On May 27, 2015, 6:05 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34558/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 6:05 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2332
>     https://issues.apache.org/jira/browse/MESOS-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move port mapping isolator configuration settings to file local scope for easier sharing.
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
> 
> Diff: https://reviews.apache.org/r/34558/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message