-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85402
-----------------------------------------------------------
What's the motivation for pulling out these constatns to the file scope instead of class scope
as it was before? I don't follow what you mean by "easier sharing".
src/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/34558/#comment136954>
s/linux ip_local_port_range/default linux ip_local_port_range [32768, 61000]/
src/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/34558/#comment136953>
s/containers/container's/ ?
src/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/34558/#comment136955>
duplicate. kill this comment.
- Vinod Kone
On May 27, 2015, 6:05 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34558/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 6:05 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2332
> https://issues.apache.org/jira/browse/MESOS-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Move port mapping isolator configuration settings to file local scope for easier sharing.
>
>
> Diffs
> -----
>
> src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502
>
> Diff: https://reviews.apache.org/r/34558/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
|