mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Wang" <markgic...@gmail.com>
Subject Re: Review Request 34529: Add non-const reference version of Option<T>::get.
Date Wed, 27 May 2015 06:40:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/
-----------------------------------------------------------

(Updated May 27, 2015, 6:40 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Addressed feedback, dublicate get(const T& _t) to getOrElse()


Bugs: MESOS-2716
    https://issues.apache.org/jira/browse/MESOS-2716


Repository: mesos


Description
-------

Add non-const reference version of Option<T>::get.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp ea79b501d9ed7b7da9636ce9c9c590738a586993

  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c


Diff: https://reviews.apache.org/r/34529/diff/


Testing
-------

make check


Thanks,

Mark Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message