mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 34195: Refactoring to use BaseFlags common functionality
Date Tue, 26 May 2015 20:58:46 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 26, 2015, 8:58 p.m.)

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Updated to be compliant with changes introduced after review comments in r/34193

Bugs: MESOS-2711

Repository: mesos

Description (updated)

Jira: MESOS-2711

All the main() methods have been refactored to use the
definition of FlagsBase::help flag and FlagsBase::usage().

This CL also tries to bring some uniformity to the
use of exit codes: if this is deemed to be worth
making it uniform, we can come up with common
rules and extend the changes here to be compliant.

This touches a lot of files, but keep scrolling, and you will see a pattern emerge.

Diffs (updated)

  src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 
  src/cli/resolve.cpp a99b6094dffc9f7aa44bcf63ad40121e1abb120b 
  src/examples/load_generator_framework.cpp be1a3bf5f16bd811cb4039c8f15478183712a426 
  src/examples/persistent_volume_framework.cpp 8a893fcfa3d5d988a88fdeaf0bfc08e0a49b7a65 
  src/health-check/main.cpp a4ce742ab8deff1ebd99359112670493fdaeeac3 
  src/launcher/executor.cpp de6f1b104a765a8e53934154e78872b03695b24c 
  src/local/main.cpp a641b9e83862743890597a2981a9419517e7c589 
  src/log/tool/benchmark.cpp 01e55115f35d155efbea190b5308b294ba76e7cb 
  src/log/tool/initialize.cpp ccda7fb1c0f7113f865ec61adee76b2ea6180442 
  src/log/tool/read.cpp d14138502f5bc9a725deb83da505765865da017f 
  src/log/tool/replica.cpp 3985fc7df4f7153ae623589fbdd769ccbae57125 
  src/master/main.cpp d5666bc8ee8d7a0f0b8685f76d65dd1f9ac2a280 
  src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e

  src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc

  src/slave/main.cpp f762f5b06be74c391cbc336b2da28f8358952ba4 
  src/tests/main.cpp e3fff5d60c0468c0d258f2bb301efc1309c071b0 
  src/usage/main.cpp 97f55e938dc7678f8331970d8953d09218f70902 



make check

**NOTE** this fixes completely the chained changes from 34193 and makes all the tests pass.


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message