mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.
Date Tue, 26 May 2015 18:07:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review85210
-----------------------------------------------------------



docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33271/#comment136725>

    Let's show an example of a function returning const & as well please



docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33271/#comment136723>

    Can we show the 'foreach', 'foreachvalue', and 'foreachkey' case since it's such a common
pattern please?
    
    Also, let's show some more explicit alias examples.



docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33271/#comment136724>

    Why is this a bad alias?


- Benjamin Hindman


On May 20, 2015, 10:36 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33271/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 10:36 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and
Till Toenshoff.
> 
> 
> Bugs: MESOS-2629
>     https://issues.apache.org/jira/browse/MESOS-2629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up from r32630.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
> 
> Diff: https://reviews.apache.org/r/33271/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message