mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 34278: Refactor Stout Result<T> leveraging Try<Option<T>> to remove the dynamic allocation.
Date Tue, 26 May 2015 16:56:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34278/#review85199
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 21, 2015, 11:45 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34278/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 11:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Cody Maloney, Joerg Schad,
and Michael Park.
> 
> 
> Bugs: MESOS-2740
>     https://issues.apache.org/jira/browse/MESOS-2740
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Aggregate a Try<Option<T>> to leverage the RAII pattern around unrestricted
union.
> Added some comments to Result<T>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 96b0f36104bed28cc227904e34cca166435a3d38

> 
> Diff: https://reviews.apache.org/r/34278/diff/
> 
> 
> Testing
> -------
> 
> make check.
> valgrind reports fewer allocations.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message