mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Williams" <lack...@gmail.com>
Subject Re: Review Request 34361: converted hard-coded strings to consts
Date Mon, 25 May 2015 07:03:16 GMT


> On May 18, 2015, 5:48 p.m., Marco Massenzio wrote:
> > src/examples/test_hook_module.cpp, lines 36-38
> > <https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36>
> >
> >     Thanks for doing this!
> >     
> >     I'm wondering whether, as these are constants, shouldn't they be in `SCREAMING_SNAKE_CASE`
as per the [Style Guide](http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/)?
> >     
> >     I completely realize that the existing code (lines above) does not follow this
style, so I'm really wondering whether that was by design or accident?
> >     
> >     And, if the latter, would this be also a good time to fix those too?
> >     
> >     No matter what, though, this is A Good Thing.
> 
> Colin Williams wrote:
>     I'd be fine converting the other constants too, I guess just waiting on somebody
saying if it was intentional or not.

Based on other feedback, these consts ended up getting localized to bring them closer to the
place where they were needed. That makes this point moot.


- Colin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34361/#review84172
-----------------------------------------------------------


On May 25, 2015, 6:59 a.m., Colin Williams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34361/
> -----------------------------------------------------------
> 
> (Updated May 25, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2637
>     https://issues.apache.org/jira/browse/MESOS-2637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> converted hard-coded strings to consts
> 
> 
> Diffs
> -----
> 
>   src/tests/hook_tests.cpp 3ffde6d 
>   src/tests/master_tests.cpp ba3858f 
>   src/tests/slave_tests.cpp acae497 
> 
> Diff: https://reviews.apache.org/r/34361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Williams
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message