mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 12550: Merge packaging scripts into Mesos.
Date Fri, 22 May 2015 16:07:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12550/#review84924
-----------------------------------------------------------


Bad patch!

Reviews applied: [12550]

Failed command: ./support/apply-review.sh -n -r 12550

Error:
 2015-05-22 16:06:57 URL:https://reviews.apache.org/r/12550/diff/raw/ [16993/16993] ->
"12550.patch" [1]
12550.patch:17: trailing whitespace.
Build scripts to create a Mesos Debian package with [FPM](https://github.com/jordansissel/fpm)
for simple installation in a cluster. 
12550.patch:252: trailing whitespace.
Copyright: 2012 The Apache Foundation <general@apache.org> 
12550.patch:46: new blank line at EOF.
+
12550.patch:228: new blank line at EOF.
+
12550.patch:240: new blank line at EOF.
+
warning: squelched 11 whitespace errors
warning: 16 lines add whitespace errors.
Successfully applied: Merge packaging scripts into Mesos.

The 'packaging' directory provides a home for packaging scripts, init scripts, homebrews and
related code.
There's some stuff for Debian and Ubuntu included.


Review: https://reviews.apache.org/r/12550
packaging/README.md:3: trailing whitespace.
+Build scripts to create a Mesos Debian package with [FPM](https://github.com/jordansissel/fpm)
for simple installation in a cluster. 
packaging/README.md:32: new blank line at EOF.
packaging/build_mesos:176: new blank line at EOF.
packaging/conf:6: new blank line at EOF.
packaging/copyright:6: trailing whitespace.
+Copyright: 2012 The Apache Foundation <general@apache.org> 
packaging/copyright:41: new blank line at EOF.
packaging/debian/master.init:69: new blank line at EOF.
packaging/debian/mesos.postinst:30: new blank line at EOF.
packaging/debian/mesos.postrm:23: new blank line at EOF.
packaging/debian/slave.init:67: new blank line at EOF.
packaging/default/mesos:3: new blank line at EOF.
packaging/default/mesos-master:3: new blank line at EOF.
packaging/ubuntu/master.upstart:16: new blank line at EOF.
packaging/ubuntu/mesos.postinst:25: new blank line at EOF.
packaging/ubuntu/mesos.postrm:21: new blank line at EOF.
packaging/ubuntu/slave.upstart:14: new blank line at EOF.
Failed to commit patch

- Mesos ReviewBot


On July 15, 2013, 5:36 p.m., Jason Dusek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12550/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 5:36 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> The 'packaging' directory provides a home for packaging scripts, init scripts, homebrews
and related code.
> There's some stuff for Debian and Ubuntu included.
> 
> 
> Diffs
> -----
> 
>   packaging/.gitignore PRE-CREATION 
>   packaging/README.md PRE-CREATION 
>   packaging/build_mesos PRE-CREATION 
>   packaging/conf PRE-CREATION 
>   packaging/copyright PRE-CREATION 
>   packaging/debian/master.init PRE-CREATION 
>   packaging/debian/mesos.postinst PRE-CREATION 
>   packaging/debian/mesos.postrm PRE-CREATION 
>   packaging/debian/slave.init PRE-CREATION 
>   packaging/default/mesos PRE-CREATION 
>   packaging/default/mesos-master PRE-CREATION 
>   packaging/default/mesos-slave PRE-CREATION 
>   packaging/ubuntu/master.upstart PRE-CREATION 
>   packaging/ubuntu/mesos.postinst PRE-CREATION 
>   packaging/ubuntu/mesos.postrm PRE-CREATION 
>   packaging/ubuntu/slave.upstart PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12550/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dusek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message