mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 34545: Updated the allocator related docs.
Date Fri, 22 May 2015 13:27:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34545/#review84903
-----------------------------------------------------------



docs/allocation-module.md
<https://reviews.apache.org/r/34545/#comment136342>

    1. s/Allocator/The allocator
    
    2. I thought DRFD is the default and not something a 3rd party would implement as a mosule.
Don't we offer it as default module implementation?



docs/allocation-module.md
<https://reviews.apache.org/r/34545/#comment136343>

    s/need/needs



docs/allocation-module.md
<https://reviews.apache.org/r/34545/#comment136344>

    s/the calls/calls



docs/allocation-module.md
<https://reviews.apache.org/r/34545/#comment136345>

    s/reference/refer to



docs/allocation-module.md
<https://reviews.apache.org/r/34545/#comment136346>

    "if weights are specified in Sorter::add()"
    
    Can you expand on this, please? The reader has no knowledge of what Sorter::add() might
entail at this point.



docs/allocation-module.md
<https://reviews.apache.org/r/34545/#comment136347>

    s/is ready/has been written



docs/modules.md
<https://reviews.apache.org/r/34545/#comment136350>

    "Examples": either use singular here or add a second example.


- Bernd Mathiske


On May 21, 2015, 7:58 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34545/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 7:58 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2596
>     https://issues.apache.org/jira/browse/MESOS-2596
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/allocation-module.md bca54b01b80708c8265708aa9e2ef4a02fe64228 
>   docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b 
>   docs/modules.md 835c195745421938a5dc86c3c7d5777e02d660b7 
> 
> Diff: https://reviews.apache.org/r/34545/diff/
> 
> 
> Testing
> -------
> 
> Rendered the docs in MacDown and github.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message