mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 34277: Refactor Stout Try<T> leveraging Option<T> to remove dynamic allocation.
Date Thu, 21 May 2015 23:45:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34277/
-----------------------------------------------------------

(Updated May 21, 2015, 11:45 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Cody Maloney, Joerg Schad, and
Michael Park.


Bugs: MESOS-2739
    https://issues.apache.org/jira/browse/MESOS-2739


Repository: mesos


Description
-------

Aggregate an Option<T> to leverage the RAII pattern around unrestricted union.
Added some comments to Try<T>.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 8150b70611587a4bb5327e303182a0ee040157ab

  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc47a12c9540dc8d23f083e783e68f0a1af8


Diff: https://reviews.apache.org/r/34277/diff/


Testing
-------

Added an explicit None() assignment test.
make check.
valgrind reports fewer allocations.


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message