mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 32664: Add port mapping isolator statistics tests
Date Thu, 21 May 2015 21:24:44 GMT


> On April 8, 2015, 7:46 p.m., Ian Downes wrote:
> > src/tests/port_mapping_tests.cpp, line 1788
> > <https://reviews.apache.org/r/32664/diff/1/?file=911866#file911866line1788>
> >
> >     Did you consider using iperf3 which makes all features available through a library?

I looked at iperf3 but it would require creating an external helper that can be launched on
host or in a container, then generating and parsing the output. I don't believe the benefit
is worth the extra effort required.


> On April 8, 2015, 7:46 p.m., Ian Downes wrote:
> > src/tests/port_mapping_tests.cpp, line 1831
> > <https://reviews.apache.org/r/32664/diff/1/?file=911866#file911866line1831>
> >
> >     that's a scary regex! I'm guessing a lot of this would be vastly simpler if
we used the iper3 library. Did you investigate that?

Using the iperf3 library requires that we create a helper function that we spawn to execute
the tests (possible in a container), and therefore we would have to output & parse data
in some format. However, I can make the regex a lot more readable.


> On April 8, 2015, 7:46 p.m., Ian Downes wrote:
> > src/tests/port_mapping_tests.cpp, lines 1874-1881
> > <https://reviews.apache.org/r/32664/diff/1/?file=911866#file911866line1874>
> >
> >     Why do this in a shell? why not do this in code - signal the pid as desired.

I've reduced but not eliminated the use of shell script to operations that have to sometimes
run inside containers.  This allows the use of the same mechanisms to stop the helper programs
as used to start the program without having to create a separate helper program.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32664/#review79409
-----------------------------------------------------------


On April 1, 2015, 3:45 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32664/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 3:45 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add port mapping isolator statistics tests
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 
> 
> Diff: https://reviews.apache.org/r/32664/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message