mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 34559: Used the pull model to get estimations from resource estimator.
Date Thu, 21 May 2015 20:38:31 GMT


> On May 21, 2015, 7:26 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 3986
> > <https://reviews.apache.org/r/34559/diff/1/?file=966887#file966887line3986>
> >
> >     Can you add a comment here on why we forward periodically instead of after every
update?

Discussed with Vinod offline. It's hard to explain in this review. We'll wait for the next
review to add this comments.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34559/#review84768
-----------------------------------------------------------


On May 21, 2015, 7:06 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34559/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2735
>     https://issues.apache.org/jira/browse/MESOS-2735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used the pull model to get estimations from resource estimator.
> 
> This reverts the changes made in https://reviews.apache.org/r/34299/.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/resource_estimator.hpp d64c6984f5c0622adde912c6af4857e389171822

>   src/slave/resource_estimator.hpp 5a6367c4cf6b840e3ad87a5eb2e758ae441704de 
>   src/slave/resource_estimator.cpp 7b7b49940aeff84a2d0ea3042f5de96f36d67130 
>   src/slave/slave.hpp d82b10cbd229ce93be8391d4911b6d85c821ccfb 
>   src/slave/slave.cpp 8e88482f41f37ce7f2559fe793565b66ac46fb35 
>   src/tests/mesos.hpp a60df75350beab8d7091cbe66213ecd920942fa4 
> 
> Diff: https://reviews.apache.org/r/34559/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message