mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 34141: AppC provsioning backend.
Date Thu, 21 May 2015 20:25:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/#review84774
-----------------------------------------------------------



src/slave/containerizer/provisioners/appc/backend.cpp
<https://reviews.apache.org/r/34141/#comment136131>

    Use --archive to preserver permissions, timestamps etc?



src/slave/containerizer/provisioners/appc/backend.cpp
<https://reviews.apache.org/r/34141/#comment136125>

    Running this as an unconstrained subprocess risks impacting the performance of every container
on the system.  Could we not launch this inside a container?


- Paul Brett


On May 13, 2015, 12:48 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34141/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simple copy backend that forms the rootfs by copying each layer.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 
>   src/slave/containerizer/provisioners/appc/backend.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
> 
> Diff: https://reviews.apache.org/r/34141/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message