mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.
Date Wed, 20 May 2015 23:30:09 GMT


> On May 20, 2015, 9:27 p.m., Vinod Kone wrote:
> > support/post-reviews.py, line 200
> > <https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200>
> >
> >     if someone specifies "--tracking-branch" on the command line, does that mean
it'll be passed to 'rbt' twice?
> 
> Jie Yu wrote:
>     This is the semantics currently. If someone does --tracking-branch=master right now,
the same argument will be appended twice because we alreays append all args to rbt post `command
= command + sys.argv[1:]`.

I fixed it anyway.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/#review84589
-----------------------------------------------------------


On May 20, 2015, 6:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34488/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 6:56 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed post-reviews.py to configure tracking branch.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 
> 
> Diff: https://reviews.apache.org/r/34488/diff/
> 
> 
> Testing
> -------
> 
> Used it to post this review.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message