mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.
Date Wed, 20 May 2015 23:00:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503/#review84608
-----------------------------------------------------------



support/post-reviews.py
<https://reviews.apache.org/r/34503/#comment135945>

    Not yours, but perhaps "from subprocess import Popen"?



support/post-reviews.py
<https://reviews.apache.org/r/34503/#comment135947>

    unrelated, but where's this used?



support/post-reviews.py
<https://reviews.apache.org/r/34503/#comment135948>

    What happens to parent_review_request_id here?



support/post-reviews.py
<https://reviews.apache.org/r/34503/#comment135942>

    I presume this won't work if you choose to skip updating/creating some reviews?


- Ian Downes


On May 20, 2015, 3:50 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34503/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now contributors don't have to manually set the depends on field!
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 
> 
> Diff: https://reviews.apache.org/r/34503/diff/
> 
> 
> Testing
> -------
> 
> Tested with a chain of reviews.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message