mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.
Date Wed, 20 May 2015 12:36:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34319/#review84502
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/34319/#comment135818>

    Any reason why `Option<>` was chosen? As I see in the file, we mostly use `Return<>`
and `Try<>` and I think in these cases the prefered type is `Return<>`



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/34319/#comment135819>

    Ditto.


- Alexander Rojas


On May 17, 2015, 3:40 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34319/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 3:40 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-994
>     https://issues.apache.org/jira/browse/MESOS-994
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored os::getenv to return an option and updated os::path accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be90edb134465751d093b61e84fd6b16f1c

> 
> Diff: https://reviews.apache.org/r/34319/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message