mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave
Date Wed, 20 May 2015 06:41:52 GMT


> On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
> > include/mesos/executor/executor.proto, line 117
> > <https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line117>
> >
> >     No corresponding Type for this?
> >     
> >     Also, how and when is this used?
> 
> Alexander Rojas wrote:
>     I had problems with the naming and I can use your help. The core issue here is, the
message is use for resubscription. It just adds the list of unacknowledged messages and that
is the difference with the subscription message which is mostly empty, any idea for a name?

Now called resubscribe.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review82545
-----------------------------------------------------------


On May 20, 2015, 8:41 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33823/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 8:41 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.hpp PRE-CREATION 
>   include/mesos/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
> 
> Diff: https://reviews.apache.org/r/33823/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message