mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 34193: Refactored common functionality into BaseFlags
Date Tue, 19 May 2015 22:31:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193/
-----------------------------------------------------------

(Updated May 19, 2015, 10:31 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Changes
-------

Addressed Joris comments


Bugs: MESOS-2711
    https://issues.apache.org/jira/browse/MESOS-2711


Repository: mesos


Description
-------

Jira: MESOS-2711

Every program that uses stout's `BaseFlags` ends up
re-implementing the `printUsage()` function, and adding
a `bool help` (and associated --help flag); this functionality
has now been refactored in the base class and is available everywhere.

This change attempts to be backward-compatible, so it
does not alter the behavior of the program when --help is
invoked (by, eg, automatically printing usage and exiting)
but leaves up to the caller to check for `flags.help` and then
decide what action to take.

There is now a default behavior for the "leader" ("Usage: <prog name> [options]")
but the client API allows to modify that too.

Note - anywhere I found the use of the `--help` flag the behavior was the same: 
print usage and exit (see also https://reviews.apache.org/r/34195).


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp fb383b463a99924483634eebf22bf34de318f920

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 00281195b53d2597bdb46e3fe6cd9d46a5e9b1f1


Diff: https://reviews.apache.org/r/34193/diff/


Testing
-------

make check

**NOTE** this change by itself breaks the build, because the --help is redefined everywhere
(16 places, as of last count): CL 34195 fixes that and makes all build/tests pass.


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message