mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 34309: Support manipulating scheduler policy on Linux.
Date Tue, 19 May 2015 21:01:53 GMT


> On May 19, 2015, 9:53 a.m., Niklas Nielsen wrote:
> > src/linux/sched.hpp, line 51
> > <https://reviews.apache.org/r/34309/diff/2/?file=963181#file963181line51>
> >
> >     Want to add some context to which pid that you couldn't get the policy for?
For example: "Failed to get scheduler policy for pid: 1234"
> 
> Vinod Kone wrote:
>     Nik, the general rule is that we don't include stuff in the log message that the
caller already has access to, because it makes it hard to chain errors (e.g., the caller has
no idea whether to include pid in its own log message or not).

Okay - didn't know. Should we put this in the style guide then?

We don't print the pid in the call site either in: https://reviews.apache.org/r/34310


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84331
-----------------------------------------------------------


On May 19, 2015, 12:58 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34309/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 12:58 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2652
>     https://issues.apache.org/jira/browse/MESOS-2652
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support manipulating scheduler policy on Linux.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
>   src/linux/sched.hpp PRE-CREATION 
>   src/tests/sched_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34309/diff/
> 
> 
> Testing
> -------
> 
> Added test.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message