mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 33793: HTTP headers should be considered case-insensitive.
Date Tue, 19 May 2015 20:06:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33793/#review84376
-----------------------------------------------------------


Thanks! Can you have a look at my comments on r/34068/ and apply them here as well?


3rdparty/libprocess/src/tests/http_tests.cpp
<https://reviews.apache.org/r/33793/#comment135596>

    How about just using "20". :)



3rdparty/libprocess/src/tests/http_tests.cpp
<https://reviews.apache.org/r/33793/#comment135598>

    The left hand side should hold the expected value, so flip the order of the arguments
here. Also, these should fit on one line, ditto below.



3rdparty/libprocess/src/tests/http_tests.cpp
<https://reviews.apache.org/r/33793/#comment135597>

    Ditto here. Don't bother with stringify.


- Ben Mahler


On May 9, 2015, 3:37 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33793/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 3:37 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-328
>     https://issues.apache.org/jira/browse/MESOS-328
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> HTTP headers should be considered case-insensitive.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 058fa02eeecdf31023db731734257a924d770079

>   3rdparty/libprocess/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894 
>   3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de

> 
> Diff: https://reviews.apache.org/r/33793/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message