mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 33792: Extend hashmap to support custom equality and hash
Date Tue, 19 May 2015 20:05:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33792/#review84369
-----------------------------------------------------------

Ship it!


Thanks hsaodent! Just one minor change below.


3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
<https://reviews.apache.org/r/33792/#comment135580>

    Can we change this to 'Equal'? s/Pred/Equal/
    
    This describes what it does, and I also noticed you called it 'Equal' in https://reviews.apache.org/r/33793
;)


- Ben Mahler


On May 12, 2015, 12:55 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33792/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 12:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Ben Mahler.
> 
> 
> Bugs: MESOS-328
>     https://issues.apache.org/jira/browse/MESOS-328
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extend hashmap to support custom equality and hash
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 24dc369ec271ec2f35449e6ccf49c5b829ca6ce8

> 
> Diff: https://reviews.apache.org/r/33792/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message