mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 34375: Removed use of namespace aliases.
Date Tue, 19 May 2015 02:02:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34375/#review84251
-----------------------------------------------------------


This might be a valid namespace alias use case that we hadn't considered, because there is
no way to be able to write just `http::Response` otherwise, is there?

Seems quite verbose to write process::http everywhere, and on the otherhand just having `Request`
or `Response` seems to miss the context of it being http, thoughts?

- Ben Mahler


On May 18, 2015, 11:13 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34375/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 11:13 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e 
>   src/slave/slave.cpp 8e88482f41f37ce7f2559fe793565b66ac46fb35 
>   src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b 
>   src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 
> 
> Diff: https://reviews.apache.org/r/34375/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message