mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 34388: Index slaves by UPID in the master.
Date Tue, 19 May 2015 01:56:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34388/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-2507
    https://issues.apache.org/jira/browse/MESOS-2507


Repository: mesos


Description
-------

The idea here is to index the Slaves by both SlaveID and UPID.

Boost's multi_index_container provides such functionality, but is potentially overly complicated
for what we need here. So I've just added a struct that hides two underlying maps, and added
a TODO to weigh multi_index_container vs our own indexing abstraction in stout. We can punt
on this until more use-cases show up.


Diffs
-----

  src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62 
  src/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e 

Diff: https://reviews.apache.org/r/34388/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message