mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 34139: AppC image discovery.
Date Mon, 18 May 2015 23:37:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139/#review84196
-----------------------------------------------------------



src/slave/containerizer/provisioners/appc/discovery.hpp
<https://reviews.apache.org/r/34139/#comment135337>

    AppcImage is introduced in r/34142



src/slave/containerizer/provisioners/appc/discovery.cpp
<https://reviews.apache.org/r/34139/#comment135389>

    Please see my comment in r/34142. I would like to suggest have AppcImage drive discover
instead of AppcPP.



src/slave/containerizer/provisioners/appc/discovery.cpp
<https://reviews.apache.org/r/34139/#comment135390>

    nit: this call is duplicated? maybe have discover just understand a raw canonicalized
string?



src/slave/flags.cpp
<https://reviews.apache.org/r/34139/#comment135335>

    should introduce all avaiable options to users here? Ditto to other flags introduced?


- Chi Zhang


On May 13, 2015, 12:47 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34139/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 12:47 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Local and simple discovery only.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 
>   src/slave/containerizer/provisioners/appc/discovery.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
> 
> Diff: https://reviews.apache.org/r/34139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message