mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Review Request 34378: Fixed the dependency between 'summarize' and 'model'.
Date Mon, 18 May 2015 23:23:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34378/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
-------

Since `summarize` captures the important fields of an object, `model` will always be a superset
of it.
We can see that `model(const Framework&)` calls `summarize(const Framework&)` and
augments additional fields.

This patch removes the unnecessary forward declaration and makes `model(const Slave&)`
depend on `summarize(const Slave&)` instead.


Diffs
-----

  src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e 

Diff: https://reviews.apache.org/r/34378/diff/


Testing
-------

make check


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message