mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 34017: Update existing lambdas to meet style guide
Date Mon, 18 May 2015 21:17:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34017/#review84221
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 17, 2015, 10:11 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34017/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 10:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2670
>     https://issues.apache.org/jira/browse/MESOS-2670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> According Joris advice, replace the 'lambda::bind' expressions match these rules:
> 
> 1. Binds to a static function without any side-effects.
> 2. Is self contained (i.e. does not rely on contextual parameters)
> 3. Does not bind in any arguments. (i.e. only uses lambda::_N for arguments)
> 4. Is only called in 1 place OR is so small that it is ok to repeat the code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 588bd3e40a0b350ceca15bb8f3f78290ba41d173 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a

> 
> Diff: https://reviews.apache.org/r/34017/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message