mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 34295: Added maintainers documentation.
Date Sun, 17 May 2015 07:03:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34295/#review84007
-----------------------------------------------------------


Thank you for putting this together. This will help people decide where to turn when they
need advice or a shepherd/reviewer.
Please allow me to suggest some additional components and maintainers, and clarify some terminology/formatting.


docs/committers.md
<https://reviews.apache.org/r/34295/#comment135184>

    I'm not sure I'm bought into this "widely maintained components" terminology or philosophy.
I agree that everybody should maintain the tests, but "tests" isn't even listed as a component,
presumably for that reason.
    "Build and support tooling", however, is listed as a component, and there are definitely
some I would consult about build issues or reviewbot/mesos-style before others. Same goes
for documentation.
    
    As you mention just before, everyone is responsible for the entire codebase, so there's
no need to list the "widely maintained" components. Let's only call out "components" here
where there are individual committers with increased context/interest/perspective.



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135183>

    I looked over the JIRA project components and here are the extras I'd like to see covered
here:
    - allocation
    - fetcher
    - project website (dlester)
    - statistics (dhamon?)



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135181>

    Nominating: tstclair, vinodkone



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135182>

    Nominating: dlester



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135133>

    Is this the Master/Slave API, or everything in master.cpp and slave.cpp? If the latter,
I would suggest splitting these up. If the former, we should say "API".



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135185>

    Does the ordering mean anything here? When reading it, I assume that the first person
listed is the person I should bother first, which is BenH on 8 different components. In fact,
there are only 2 components with maintainers where BenH is not on the list.
    I would hope that, over time, we can balance out the maintainers list so that nobody is
primary maintainer for more than a few components. This will ease the load on the busiest
committers.



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135178>

    Are these really different enough to separate?



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135180>

    I'll volunteer to help out here, if you'll have me.



docs/committers.md
<https://reviews.apache.org/r/34295/#comment135179>

    There were talks of moving the CLI and/or WebUI outside of the repo, for external maintenance.
Then we wouldn't necessarily need Apache Mesos committers to maintain it/them.


- Adam B


On May 15, 2015, 3:25 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34295/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 3:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Dave Lester, Ian Downes, Jie Yu,
Niklas Nielsen, Till Toenshoff, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2737
>     https://issues.apache.org/jira/browse/MESOS-2737
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per the proposal thread, this adds documentation for maintainers and an initial set of
maintainers.
> 
> Please share your thoughts!
> 
> 
> Diffs
> -----
> 
>   docs/committers.md PRE-CREATION 
>   docs/home.md 4b8e7f8d2dcd9e26816353c939a2a5c18314ac45 
> 
> Diff: https://reviews.apache.org/r/34295/diff/
> 
> 
> Testing
> -------
> 
> Markdown: https://gist.github.com/bmahler/962d1ddc9f14e1d342a6
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message