mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 34298: Explictly validated that all resources specified in reserve or unreserve operations are dynamically reserved.
Date Fri, 15 May 2015 23:31:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34298/#review84001
-----------------------------------------------------------

Ship it!



src/master/validation.cpp
<https://reviews.apache.org/r/34298/#comment135101>

    ```
    if (!Resources::isDynamicallyReserved(resource)) {
      ...
    }
    ```



src/master/validation.cpp
<https://reviews.apache.org/r/34298/#comment135102>

    Ditto.


- Jie Yu


On May 15, 2015, 11:26 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34298/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 11:26 p.m.)
> 
> 
> Review request for mesos, Jie Yu and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Did this for consistency with validateDiskInfo().
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp c3e96ae0e684f3f365e9aa365bccc953d32b0452 
> 
> Diff: https://reviews.apache.org/r/34298/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message