mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.
Date Fri, 15 May 2015 17:56:38 GMT


> On May 14, 2015, 9:38 a.m., Niklas Nielsen wrote:
> > src/examples/test_hook_module.cpp, lines 146-150
> > <https://reviews.apache.org/r/29947/diff/10/?file=958466#file958466line146>
> >
> >     Looks a bit dense; can we break it up a bit?
> 
> Kapil Arya wrote:
>     Ideally, this whole block would be replaced by a single statement that does all this
behind the curtains. For that reason, I would prefer to keep these close together to give
the impression that this is a single unit of work. If you prefer, I can add a TODO on top
of it.

It's fine - I will drop the issue.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29947/#review83786
-----------------------------------------------------------


On May 13, 2015, 1:36 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29947/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 1:36 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2226
>     https://issues.apache.org/jira/browse/MESOS-2226
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There is currently no good way to synchronize between the test body and the hook code,
so we wire a promise (owned by the test code). The technical debt is covered by the following
JIRA issue:
> 
> https://issues.apache.org/jira/browse/MESOS-2641
> 
> 
> Diffs
> -----
> 
>   src/examples/test_hook_module.cpp b25830ab6475f997422cfd2f60cc9a79e1acadfe 
>   src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 
>   src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 
> 
> Diff: https://reviews.apache.org/r/29947/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message