mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 29507: Added Configurable Slave Ping Timeouts
Date Thu, 14 May 2015 10:01:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
-----------------------------------------------------------

(Updated May 14, 2015, 3:01 a.m.)


Review request for mesos, Ben Mahler and Niklas Nielsen.


Changes
-------

Rebased


Bugs: MESOS-2110
    https://issues.apache.org/jira/browse/MESOS-2110


Repository: mesos


Description
-------

Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs)
and DEFAULT_MAX_SLAVE_PING_TIMEOUTS (5).
   
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.

Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage.
  
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.


Diffs (updated)
-----

  docs/configuration.md 54c4e31 
  docs/upgrades.md 2a15694 
  src/master/constants.hpp c386eab 
  src/master/constants.cpp 9ee17e9 
  src/master/flags.hpp 996cf38 
  src/master/flags.cpp 5798989 
  src/master/master.cpp eaea79d 
  src/messages/messages.proto 19e2444 
  src/slave/constants.hpp df02043 
  src/slave/constants.cpp 07f699a 
  src/slave/slave.hpp b62ed7b 
  src/slave/slave.cpp 132f83e 
  src/tests/partition_tests.cpp f7ee3ab 
  src/tests/slave_recovery_tests.cpp c036e9c 
  src/tests/slave_tests.cpp acae497 

Diff: https://reviews.apache.org/r/29507/diff/


Testing
-------

Manually tested slave failover/shutdown with master using different --slave_ping_timeout and
--max_slave_ping_timeouts.
Ran unit tests with shorter non-default values for ping timeouts.
`make check` with new unit tests: ShortPingTimeoutUnreachableMaster and ShortPingTimeoutUnreachableSlave


Thanks,

Adam B


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message